Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add charset #1582

Merged
merged 3 commits into from
Jul 11, 2017
Merged

Conversation

harakiri406
Copy link

MODULES-4248 New feature for Puppet Apache

Copy link
Contributor

@eputnam eputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, just a small formatting issue in the README!

README.md Outdated

Lets Apache set custom content character sets per directory and/or file extension


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please remove this last empty line and move this param up into alphabetical order for the vhost type?

@eputnam eputnam added the feature label Jul 1, 2017
@tphoney
Copy link
Contributor

tphoney commented Jul 10, 2017

@eputnam should be good to merge now !

@tphoney tphoney merged commit 1a9257a into puppetlabs:master Jul 11, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants