The base tag also needs link rewriting #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… situations. base tag is defined at https://www.w3schools.com/tags/tag_base.asp. Including this ProxyHTMLLinks line is recommended i.e. at http://httpd.apache.org/docs/current/mod/mod_proxy_html.html#proxyhtmllinks and other places.
|
This LGTM, 👍 Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base tag is defined at https://www.w3schools.com/tags/tag_base.asp. Including this ProxyHTMLLinks line is recommended i.e. at http://httpd.apache.org/docs/current/mod/mod_proxy_html.html#proxyhtmllinks and other places.
In my situation we're serving a http-only backend from apache over https, some oddities remained until we managed to fix the base url (i.e. weirdly enough google analytics javascript was fetched over http, causing a security alert).
I fail to see situations where one would want to rewrite the given URL for all other links than the base tag.