Add param for AllowOverride in the userdir.conf template #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dir.conf template This replaces the hardcoded list with an array join, similar to the existing Options line. The previously hardcoded values are used as the default for the overrides param.
|
@dstepe LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4516 Add param for AllowOverride values in userdir template
Add a param to the apache::mod::userdir class to accept an array of override value. Replace the hardcoded list in the userdir.conf.erb template with an array join, similar to the existing Options line. Use the previously hardcoded values as the default for the overrides param.
The AllowOverride directive values were previously hardcoded in the template.
https://tickets.puppetlabs.com/browse/MODULES-4516