the wsgi_script_aliases need to support array type of value

[netman2k]

Hi,

Recently, I found out that the wsgi_script_aliases parameter only supports string type of the value.
I only want to set the process-group with a WSGIScriptAlias in the HTTPD conf. as below

WSGIScriptAlias / /usr/local/djangoweb/wsgi.py process-group=djangoweb-admin

To accomplish this, I create the DSL code like this and the Puppet applies it without any error

::apache::vhost { $title :
    ip                          => $listen_ip,
    port                        => $port,
    servername                  => $server_name,
    serveraliases               => $server_aliases,
    serveradmin                 => $server_admin,
    docroot                     => $doc_root,
    wsgi_daemon_process         => $wsgi_daemonprocess_name,
    wsgi_daemon_process_options => $_wsgidaemonprocess_opts,
    wsgi_process_group          => $wsgi_daemonprocess_group,
    wsgi_script_aliases         => {
      '/' => '/usr/local/djangoweb/wsgi.py 'process-group=djangoweb-admin'
    },

But If I see the HTTPD daemon log, I can see this kind of message.

Apr 14 07:13:34 webapp.example.net httpd[18717]: Invalid option to WSGI script alias definition.

Cause the module created this in the configuration file.

WSGIScriptAlias / "/usr/local/djangoweb/wsgi.py process-group=djangoweb-admin"

So I changed the template file, _wsgi.erb. now it checks the value before applying the value directly.
After changed I can accomplish my desire state

::apache::vhost { $title :
    ip                          => $listen_ip,
    port                        => $port,
    servername                  => $server_name,
    serveraliases               => $server_aliases,
    serveradmin                 => $server_admin,
    docroot                     => $doc_root,
    wsgi_daemon_process         => $wsgi_daemonprocess_name,
    wsgi_daemon_process_options => $_wsgidaemonprocess_opts,
    wsgi_process_group          => $wsgi_daemonprocess_group,
    wsgi_script_aliases         => {
      '/' => [ 
         '/usr/local/djangoweb/wsgi.py', 
         'process-group=djangoweb-admin'
      ]
    },

[eputnam]

@netman2k , thanks for the PR!

[netman2k]

Thanks for the accept. 2017년 7월 19일 (수) 오전 6:03, Eric Putnam <notifications@github.com>님이 작성:

…

Merged #1609 <#1609>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1609 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFulM86VunCmm1j48I1WRpeYxpxNCkN8ks5sPRzggaJpZM4M9kF2> .