MODULES-4816 - new param for mod::security class #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunner
suggested changes
May 31, 2017
manifests/mod/security.pp
Outdated
| @@ -24,6 +24,7 @@ | |||
| $secrequestbodylimit = '13107200', | |||
| $secrequestbodynofileslimit = '131072', | |||
| $secrequestbodyinmemorylimit = '131072', | |||
| $deploy_security_crs = true, | |||
There was a problem hiding this comment.
Could you please name this manage_security_crs to be more similar to other parameters in the module?
- New param $manage_security_crs set to true by default so the default behaviour is unchanged. - new spec example so that the parameter is spec-tested - Add an entry in the doc about this new param
|
Here you are :) I've changed the parameter name and added an entry into the README.md file. |
|
Any news on this one ? |
|
@hunner please review changes |
hunner
approved these changes
Jul 12, 2017
hunner
added a commit
that referenced
this pull request
Jul 12, 2017
MODULES-4816 - new param for mod::security class
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
…urity-param MODULES-4816 - new param for mod::security class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$deploy_security_crsset to true by default so the defaultbehaviour is unchanged.