MODULES-3838 Pass mod_packages through init.pp to allow overrides #1631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the SCL packages on CentOS, package names have a prefix that needs to be overridden. With most other attributes in params.pp, this is possible by overriding variables passed to
Class['::apache'], but in the case ofmod_packagesit's read directly from the params file on use. This is workaroundable by not using theapache::mod::...subclasses can callingapache::mod { 'mod_name' }directly, but there is a compounding problem.The
apache::vhost::auth_kerbparameter is used for for both including theauth_kerbmodules (using class syntax rather than include, so cannot be duplicated), and for including config snippets in the generated vhost. It's not possible to make use of the config snippet whilst also needing to amend the package name.This commit follows the existing style and passes
mod_packagesthroughinit.pp, and updates all references ofapache::params::mod_packagestoapache::mod_packages. It's therefore possible to override the package names using something like: