Expose loadfile_name option to mod::python class #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a reasonable workaround for the issue. Should this be documented ? |
This is a work around to a particular clash between these
two lines.
```puppet
class{'apache::mod::python':}
class{'collectd::plugin::python':}
```
Both classes create a file resource `file{'python.load':}`
This patch allows the resource name to be configured for
`apache::mod::python` setup.
There is an altenative more perfect solution to use a better
more unique name space by default e.g `file{"apache_${_loadfile_name}:` but this
would touch so many test files....
This change is fully backwards compatible.
* [collectd::plugin::python](https://github.com/voxpupuli/puppet-collectd/blob/master/manifests/plugin.pp#L16)
|
Docs and rebased. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
Expose loadfile_name option to mod::python class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work around to a particular clash between these
two lines.
Both classes create a file resource
file{'python.load':}This patch allows the resource name to be configured for
apache::mod::pythonsetup.There is an altenative more perfect solution to use a better
more unique name space by default e.g
file{"apache_${_loadfile_name}:but thiswould touch so many test files....
This change is fully backwards compatible.