default server_tokens to prod - more secure default #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable. The readme would need updating https://github.com/puppetlabs/puppetlabs-apache#server_tokens Also, this will probably not make it in for a bit, since it's arguably a backwards-incompatible change, not a bugfix. |
|
@juju4 Apologies for the long wait, I am currently looking to merge your pr, however I would need it to be rebased first in order to effectively test it's changes on our adhoc pipeline, due to the updates made to the module since it's creation. |
|
done. Thanks |
|
@juju4 thank you for taking the time to contribute to this supported module. Many Thanks |
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
default server_tokens to prod - more secure default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: provide a sane & secure default configuration for modern webserver
This is a minor change to have more secure default for apache tokens.
Most people will not update/forget it for production.