Allow overriding passenger_group in apache::vhost #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smortex Please alter the docs to reflect your changes and add some test coverage. |
|
Working on it. The test suite lacks test for the |
Just like we can use passenger_user in a VHost, allow setting passenger_group.
There is no reason to remove the trailing newline here.
|
Done! This helped finding an unrelated problem in the passenger template 😉 |
|
@david22swan maybe the needs-docs and needs-tests labels can be removed? |
eputnam
reviewed
Mar 14, 2018
| <% if @passenger_high_performance -%> | ||
| PassengerHighPerformance <%= scope.call_function('apache::bool2httpd', [@passenger_high_performance]) %> | ||
| <% end -%> | ||
| <% if @passenger_nodejs -%> | ||
| PassengerNodejs <%= @passenger_nodejs -%> | ||
| PassengerNodejs <%= @passenger_nodejs %> |
There was a problem hiding this comment.
nice catch! i hope the config parser is hardy enough to handle a new newline :)
There was a problem hiding this comment.
I don't think so 😉
Performing sanity check on apache24 configuration:
AH00526: Syntax error on line 54 of /usr/local/etc/apache24/Vhosts/25-test.conf:
PassengerNodejs takes one argument, The Node.js command to use.
There was a problem hiding this comment.
ah ok, so we def need that newline
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
Allow overriding passenger_group in apache::vhost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like we can use
passenger_userin a VHost, allow settingpassenger_group.