Allow apache::mod::passenger::passenger_pre_start to accept multiple URIs
#1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix this passenger warning: WARNING: PassengerPreStart cannot occur within <VirtualHost> section https://www.phusionpassenger.com/library/config/apache/reference/#passengerprestart
A single VirtualHost may serve more than one application (using PassengerBaseURI [1]). In such a situation, it makes sense to preload each application by using multiple PassengerPreStart [2] 1. https://www.phusionpassenger.com/library/config/apache/reference/#passengerbaseuri 2. https://www.phusionpassenger.com/library/config/apache/reference/#passengerprestart
hunner
reviewed
Mar 29, 2018
| @@ -125,7 +125,9 @@ | |||
| PassengerPoolIdleTime <%= @passenger_pool_idle_time %> | |||
| <%- end -%> | |||
| <%- if @passenger_pre_start -%> | |||
| PassengerPreStart <%= @passenger_pre_start %> | |||
| <%- [@passenger_pre_start].flatten.compact.each do |passenger_pre_start| -%> | |||
There was a problem hiding this comment.
One alternative approach to ensuring array values than the usual [var].flatten is to use Array(var). It also has a benefit when var could be nil:
[1] pry(main)> [nil].flatten
=> [nil]
[2] pry(main)> [[]].flatten
=> []
[3] pry(main)> Array(nil)
=> []
[4] pry(main)> Array([])
=> []There was a problem hiding this comment.
Though it often has undesirable behavior when var could be a hash:
[1] pry(main)> [{}].flatten
=> [{}]
[2] pry(main)> [{:foo => :bar}].flatten
=> [{:foo=>:bar}]
[3] pry(main)> Array({})
=> []
[4] pry(main)> Array({:foo => :bar})
=> [[:foo, :bar]]
hunner
changed the title
apache::mod::passenger::passenger_pre_start to accept multiple URIs
hunner
added a commit
that referenced
this pull request
Mar 29, 2018
Allow `apache::mod::passenger::passenger_pre_start` to accept multiple URIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits improve usage of
passenger_pre_startby:PassengerPreStartoutside the<VirtualHost>block (using this directive inside is not supported and produce a warning with (at least) passenger-5.2.1);Only the generated configuration is affected, existing puppet code does not need to be modified for the fix to take effect (
passenger_pre_startis still a parameter ofapache::vhost).