Define SCL package name for mod_ldap

[treydock]

No description provided.

[turnopil]

Maybe would be a good decision add support for Amazon AMIs because in AWS apache2.4 mod_ldap package called 'mod24_ldap' but for 2.2 - mod_authz_ldap

The error
ESC[1;31mError: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, 'regsubst' parameter 'target' expects a value of type Array or String, got Undef (file: /etc/puppetlabs/code/modules/apache/manifests/mod.pp, line: 55, column: 19) (file: /etc/puppetlabs/code/modules/apache/manifests/mod/ldap.pp, line: 16) on node *******[0m

[lionce]

Hello @treydock ,

Thank you for your contribution. In order to merge this PR, please resolve the conflicts.

Cheers!

[treydock]

@lionce Looks like the acceptance tests for SCL logic were removed but there are no corresponding unit tests. 6006ca2 leads me to believe this was intentional but I'm not seeing unit tests to replace the acceptance tests. Should I go ahead and remove my changes that conflict even though no test coverage?

[lionce]

Hello @treydock ,

Yes, we removed some acceptance tests because they were testing the connection to a specific port, or the server answer. Most of them were replaced by unit tests. In order to increase the test coverage, I would really appreciate if you will add a unit test to cover this case. Many thanks!

Cheers!

[treydock]

@lionce Added unit tests for changes in this PR.

[treydock]

Also had to add $conf_enabled as needed by main apache class and was throwing undefined variable errors.

[lionce]

Hello @treydock ,

Thank you for this PR. It looks good to me!

Cheers