always quote ExpiresDefault in vhost::directories #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was already done in expires.conf, but not in a vhost
evgeni
added a commit
to evgeni/foreman-infra
that referenced
this pull request
Oct 10, 2019
this is needed until puppetlabs/puppetlabs-apache#1958 is merged and we have that deployed
|
unrelated test failure is unrelated 🤷♀️ |
evgeni
added a commit
to theforeman/foreman-infra
that referenced
this pull request
Oct 10, 2019
this is needed until puppetlabs/puppetlabs-apache#1958 is merged and we have that deployed
|
This would be breaking since users might already work around this by adding quotes. |
|
Investigating the weird syntax check fail, may need to add a maint commit and have you rebase once I fix it. |
|
Fixed the problem and merged in at #1959, tests are now green. |
|
Looks like tests ran again and passed now, so I don't need to rebase, right? |
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
always quote ExpiresDefault in vhost::directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was already done in expires.conf, but not in a vhost