Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-8662) Correction in manifests/mod/ssl.pp for SLES 11 #1963

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

sanfrancrisko
Copy link
Contributor

Description

There were Pipelines CI test failures being caused by Apache not being able to load the SSL module on SLES 11: 

https://pipelines.puppet.com/team-modules/builds/599671

      2) apache::vhost define parameter tests applies cleanly
         On host `j3ye05rmc16s212.delivery.puppetlabs.net'
         Failure/Error: apply_manifest(pp, catch_failures: true)
         RuntimeError:
           apply manifest failed
           ` puppet apply /tmp/manifest_20191029_43621_1a8n2bk.pp --detailed-exitcodes`
           with exit code 6 (expected: [0, 2])
           ====== Start output of failed Puppet apply ======
           Warning: Scope(Class[Apache::Mod::Prefork]): For newer versions of Apache, $maxclients is deprecated, please use $maxrequestworkers.
           Error: /Stage[main]/Apache::Service/Service[httpd]: Failed to call refresh: Could not restart Service[httpd]: Execution of '/sbin/service apache2 restart' returned 1: httpd2-prefork: Syntax error on line 43 of /etc/apache2/httpd.conf: Syntax error on line 1 of /etc/apache2/mods-enabled/ssl.load: Cannot load /usr/lib64/apache2-worker/mod_ssl.so into server: /usr/lib64/apache2-worker/mod_ssl.so: cannot open shared object file: No such file or directory
           Error: /Stage[main]/Apache::Service/Service[httpd]: Could not restart Service[httpd]: Execution of '/sbin/service apache2 restart' returned 1: httpd2-prefork: Syntax error on line 43 of /etc/apache2/httpd.conf: Syntax error on line 1 of /etc/apache2/mods-enabled/ssl.load: Cannot load /usr/lib64/apache2-worker/mod_ssl.so into server: /usr/lib64/apache2-worker/mod_ssl.so: cannot open shared object file: No such file or directory 

Upon investigation, it appears as though the path to the mod_ssl.so is incorrect: https://github.com/cmccrisken-puppet/puppetlabs-apache/blob/caf1c141d9a3820ba1b74469241eee6c2feeb332/manifests/mod/ssl.pp#L162

It appears to have been updated correctly in other places in our code base:

https://github.com/search?q=org%3Apuppetlabs+%2Fusr%2Flib64%2Fapache2-prefork&type=Code

Making the same change to manifests/mod/ssl.pp results in the test passing.

@sanfrancrisko sanfrancrisko requested a review from a team as a code owner October 30, 2019 10:58
@sanfrancrisko
Copy link
Contributor Author

Please note, we'll still expect CI failures until the issues outlined in FM-8656 are resolved.

@david22swan david22swan merged commit 009e4e0 into puppetlabs:master Oct 30, 2019
@sanfrancrisko sanfrancrisko deleted the FM-8662 branch October 30, 2019 12:17
@sanfrancrisko sanfrancrisko changed the title (FM-8662) Correct in manifests/mod/ssl.pp for SLES 11 (FM-8662) Correction in manifests/mod/ssl.pp for SLES 11 Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants