(MODULES-10360) Fix icon paths for RedHat systems #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icon suffix '-20x22' is removed when @osfamily == 'RedHat' is true. This way icon paths are correct on RedHat systems and remain unchanged for other OSes.
michaeltlombardi
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
LGTM! Thank you so much for the contribution, @2and3makes23!
michaeltlombardi
changed the title
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
(MODULES-10360) Fix icon paths for RedHat systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon paths in autoindex.conf.erb are not correct on systems with @osfamily == 'RedHat' or @osfamily == 'Suse'.
The proposed patch removes the filename suffix '-20x22' on those systems.
This way compatibility with systems noted in metadata.json is ensured.
The proposed patch would solve: https://tickets.puppetlabs.com/projects/MODULES/issues/MODULES-10360?filter=allissues
Thank you for your time and effort.