(IAC-746) - Add ubuntu 20.04 support #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
May 20, 2020
| agent_family: ${{ matrix.agent_family }} | ||
| LitmusAcceptancePuppet6: | ||
| env: | ||
| HONEYCOMB_WRITEKEY: 7f3c63a70eecc61d635917de46bea4e6 |
There was a problem hiding this comment.
Shouldn't you use secrets for this?
There was a problem hiding this comment.
@ekohl Sorry for the late reply, since this is a writekey and can only be used to send events to a specific dataset we don't currently hide it. We may look into it the possibility in the future however, depending on how things turn out.
david22swan
force-pushed
the
pdksync_IAC-746
branch
4 times, most recently
from
4921cdb
to
428d26a
Compare
david22swan
force-pushed
the
pdksync_IAC-746
branch
2 times, most recently
from
8a713e5
to
2c52f27
Compare
david22swan
force-pushed
the
pdksync_IAC-746
branch
2 times, most recently
from
0584367
to
1724e54
Compare
david22swan
changed the title
david22swan
force-pushed
the
pdksync_IAC-746
branch
from
d222631
to
b03481a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2032 +/- ##
==========================================
+ Coverage 57.87% 58.49% +0.61%
==========================================
Files 13 12 -1
Lines 235 212 -23
==========================================
- Hits 136 124 -12
+ Misses 99 88 -11
Continue to review full report at Codecov.
|
david22swan
changed the title
pmcmaw
approved these changes
Jun 4, 2020
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
(IAC-746) - Add ubuntu 20.04 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IAC-746
pdk version:
1.17.0