Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IPv6 CIDRs for proxy_protocol_exceptions in mod remoteip #2033

Merged
merged 1 commit into from
May 27, 2020

Conversation

thechristschn
Copy link

This is the same fix as in #1891

@thechristschn thechristschn requested a review from a team as a code owner May 23, 2020 12:17
@puppet-community-rangefinder
Copy link

apache::mod::remoteip is a class

Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #2033 into master will increase coverage by 0.61%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
+ Coverage   57.87%   58.49%   +0.61%     
==========================================
  Files          13       12       -1     
  Lines         235      212      -23     
==========================================
- Hits          136      124      -12     
+ Misses         99       88      -11     
Impacted Files Coverage Δ
lib/puppet/functions/apache/apache_pw_hash.rb 0.00% <0.00%> (ø)
lib/puppet/functions/apache/bool2httpd.rb 0.00% <ø> (ø)
lib/puppet/functions/apache/pw_hash.rb 0.00% <0.00%> (ø)
lib/puppet/functions/apache_pw_hash.rb 0.00% <0.00%> (ø)
lib/puppet/functions/bool2httpd.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 983b1fd...250e0f4. Read the comment docs.

@sheenaajay
Copy link
Contributor

Thank you @thechristschn for submitting the PR.

@sheenaajay sheenaajay merged commit b98ace4 into puppetlabs:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants