Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure default shared lib path for mod_wsgi on RHEL8 #2063

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

nbarrientos
Copy link
Contributor

RHEL8:

  # rpm -ql python3-mod_wsgi | grep \.so$
  /usr/lib64/httpd/modules/mod_wsgi_python3.so

RHEL7:

  # rpm -ql mod_wsgi | grep \.so$
  /usr/lib64/httpd/modules/mod_wsgi.so

Tests might need to be changed. The package name selection has already been patched in commit d346b76d1aab954b642c55942d3ff8cf6cb578ac.

@nbarrientos nbarrientos requested a review from a team as a code owner September 4, 2020 08:10
@puppet-community-rangefinder
Copy link

apache::params is a class

Breaking changes to this file WILL impact these 11 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@3d008c9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2063   +/-   ##
=======================================
  Coverage        ?   58.49%           
=======================================
  Files           ?       12           
  Lines           ?      212           
  Branches        ?        0           
=======================================
  Hits            ?      124           
  Misses          ?       88           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d008c9...f31e392. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @nbarrientos, thank you for the contribution! You can find the tests specific to these changes here and to be sure that everything it's fine we can take a look at the tests. Let me know if you need help, cheers!

@nbarrientos nbarrientos force-pushed the rhel8_wsgi_sopath branch 2 times, most recently from 1cf065f to 08b1579 Compare September 9, 2020 12:47
RHEL8:
  # rpm -ql python3-mod_wsgi | grep \.so$
  /usr/lib64/httpd/modules/mod_wsgi_python3.so

RHEL7:
  # rpm -ql mod_wsgi | grep \.so$
  /usr/lib64/httpd/modules/mod_wsgi.so
@nbarrientos
Copy link
Contributor Author

Hi @daianamezdrea. It's done, the extra context assures that with the default configuration the module knows what RPM and what path to the shared object have to be configured on RHEL8 systems

https://travis-ci.org/github/puppetlabs/puppetlabs-apache/jobs/725579005#L888

@daianamezdrea
Copy link
Contributor

Thank you @nbarrientos for the fast response and work! This looks good to me, I'll merge the PR. Cheers!

@daianamezdrea daianamezdrea merged commit 7e3d059 into puppetlabs:main Sep 10, 2020
mwhahaha added a commit to mwhahaha/puppetlabs-apache that referenced this pull request Jul 26, 2021
This change updates the version handling to better future proof the
logic when newer versions are shipped. This should prevent having to add
things like puppetlabs#2063, puppetlabs#2021, puppetlabs#2038, etc.
daveseff pushed a commit to daveseff/puppetlabs-apache that referenced this pull request Jul 19, 2022
This change updates the version handling to better future proof the
logic when newer versions are shipped. This should prevent having to add
things like puppetlabs#2063, puppetlabs#2021, puppetlabs#2038, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants