-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure default shared lib path for mod_wsgi on RHEL8 #2063
Conversation
apache::params is a classBreaking changes to this file WILL impact these 11 modules (exact match):Breaking changes to this file MAY impact these 16 modules (near match):This module is declared in 174 of 575 indexed public
|
Codecov Report
@@ Coverage Diff @@
## main #2063 +/- ##
=======================================
Coverage ? 58.49%
=======================================
Files ? 12
Lines ? 212
Branches ? 0
=======================================
Hits ? 124
Misses ? 88
Partials ? 0 Continue to review full report at Codecov.
|
|
Hi @nbarrientos, thank you for the contribution! You can find the tests specific to these changes here and to be sure that everything it's fine we can take a look at the tests. Let me know if you need help, cheers! |
1cf065f
to
08b1579
Compare
RHEL8: # rpm -ql python3-mod_wsgi | grep \.so$ /usr/lib64/httpd/modules/mod_wsgi_python3.so RHEL7: # rpm -ql mod_wsgi | grep \.so$ /usr/lib64/httpd/modules/mod_wsgi.so
08b1579
to
f31e392
Compare
|
Hi @daianamezdrea. It's done, the extra context assures that with the default configuration the module knows what RPM and what path to the shared object have to be configured on RHEL8 systems https://travis-ci.org/github/puppetlabs/puppetlabs-apache/jobs/725579005#L888 |
|
Thank you @nbarrientos for the fast response and work! This looks good to me, I'll merge the PR. Cheers! |
This change updates the version handling to better future proof the logic when newer versions are shipped. This should prevent having to add things like puppetlabs#2063, puppetlabs#2021, puppetlabs#2038, etc.
This change updates the version handling to better future proof the logic when newer versions are shipped. This should prevent having to add things like puppetlabs#2063, puppetlabs#2021, puppetlabs#2038, etc.
RHEL8:
RHEL7:
Tests might need to be changed. The package name selection has already been patched in commit d346b76d1aab954b642c55942d3ff8cf6cb578ac.