Add ssl_proxy_machine_cert_chain param to vhost class #2072
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Apache vhost proxy config option SSLProxyMachineCertificateChainFile. Reference: https://httpd.apache.org/docs/current/mod/mod_ssl.html#sslproxymachinecertificatechainfile
Codecov Report
@@ Coverage Diff @@
## main #2072 +/- ##
=======================================
Coverage ? 58.49%
=======================================
Files ? 12
Lines ? 212
Branches ? 0
=======================================
Hits ? 124
Misses ? 88
Partials ? 0 Continue to review full report at Codecov.
|
igalic
reviewed
Oct 4, 2020
| @@ -9070,6 +9070,20 @@ apache::vhost { 'sample.example.net': | |||
|
|
|||
| Default value: `undef` | |||
|
|
|||
| ##### `ssl_proxy_machine_cert_chain` | |||
|
|
|||
| Data type: `Any` | |||
There was a problem hiding this comment.
it would be nice if we could have this as Stdlib::Absolutepath… eventually.
sanfrancrisko
changed the title
sanfrancrisko
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Agree with your comment @igalic , however, happy enough to merge now.
Thanks for the enhancement @AbelNavarro 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Apache vhost proxy config option SSLProxyMachineCertificateChainFile.
Reference: https://httpd.apache.org/docs/current/mod/mod_ssl.html#sslproxymachinecertificatechainfile