Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon path #2079

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

yakatz
Copy link
Contributor

@yakatz yakatz commented Oct 26, 2020

Allow replacing the default /icons/ path with a custom path for the icons.

@yakatz yakatz requested a review from a team as a code owner October 26, 2020 03:35
@puppet-community-rangefinder
Copy link

apache::mod::alias is a class

Breaking changes to this file WILL impact these 3 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

apache::mod::autoindex is a class

that may have no external impact to Forge modules.

apache::params is a class

Breaking changes to this file WILL impact these 11 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@3877dd9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2079   +/-   ##
=======================================
  Coverage        ?   57.40%           
=======================================
  Files           ?       12           
  Lines           ?      216           
  Branches        ?        0           
=======================================
  Hits            ?      124           
  Misses          ?       92           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3877dd9...ed82074. Read the comment docs.

@adrianiurca
Copy link
Contributor

Hi @yakatz, thank you for your contribution.

@adrianiurca adrianiurca merged commit 9ee3729 into puppetlabs:main Oct 26, 2020
@yakatz yakatz deleted the feature/change_icon_path branch October 26, 2020 16:30
@pmcmaw pmcmaw added the feature label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants