Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10887) Set use_servername_for_filenames for defaults #2103

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

towo
Copy link
Contributor

@towo towo commented Dec 4, 2020

The default vhost definitions are called without
use_servername_for_filenames being set, which leads to a deprecation
warning on every run.

With this PR, the parameters are added to the default entries and thus
avoid generating said error message.

This was verified on a local installation.

@towo towo requested a review from a team as a code owner December 4, 2020 23:08
@puppet-community-rangefinder
Copy link

apache is a class

Breaking changes to this file WILL impact these 147 modules (exact match):
Breaking changes to this file MAY impact these 63 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

The default vhost definitions are called without
`use_servername_for_filenames` being set, which leads to a deprecation
warning on every run.

With this PR, the parameters are added to the default entries and thus
avoid generating said error message.

This was verified on a local installation.
@towo
Copy link
Contributor Author

towo commented Dec 4, 2020

Force pushed to fix a typo in the commit message.

@sanfrancrisko sanfrancrisko self-assigned this Dec 7, 2020
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @towo

I've raised IAC-1288 to improve this logging, based on your feedback and this PR.

@sanfrancrisko sanfrancrisko merged commit 4a084fc into puppetlabs:main Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants