-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FIX) Correct PHP packages on Ubuntu 16.04 #2111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue spotted. I'm also trying to get a #2114 across the line to resolve the syntax check failures being caused at the moment. Some issues with that PR, but once it's merged, you can rebase and it should hopefully get your tests passing 🤞
Codecov Report
@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 57.40% 56.36% -1.05%
==========================================
Files 12 12
Lines 216 220 +4
==========================================
Hits 124 124
- Misses 92 96 +4
Continue to review full report at Codecov.
|
|
RHEL 7 acceptance test failed with some internal server error so I'm guessing that's unrelated. |
This corrects some module packages for Ubuntu 16.04. suphp was actually removed. The other packages are transitional packages. Using the modern ones aligns them with newer versions. It also greatly simplifies the params code.
96e429d
to
2152f74
Compare
Yeah, I doubt it's related to your change - I'll keep an eye on it on this 2nd run after the rebase 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @ekohl !
This corrects some module packages for Ubuntu 16.04. suphp was actually removed. The other packages are transitional packages. Using the modern ones aligns them with newer versions. It also greatly simplifies the params code.