Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FIX) Correct PHP packages on Ubuntu 16.04 #2111

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Jan 5, 2021

This corrects some module packages for Ubuntu 16.04. suphp was actually removed. The other packages are transitional packages. Using the modern ones aligns them with newer versions. It also greatly simplifies the params code.

@ekohl ekohl requested a review from a team as a code owner January 5, 2021 16:26
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue spotted. I'm also trying to get a #2114 across the line to resolve the syntax check failures being caused at the moment. Some issues with that PR, but once it's merged, you can rebase and it should hopefully get your tests passing 🤞

manifests/params.pp Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #2111 (96e429d) into main (0c19106) will decrease coverage by 1.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
- Coverage   57.40%   56.36%   -1.05%     
==========================================
  Files          12       12              
  Lines         216      220       +4     
==========================================
  Hits          124      124              
- Misses         92       96       +4     
Impacted Files Coverage Δ
lib/facter/apache_version.rb 55.00% <ø> (ø)
lib/puppet/functions/apache/apache_pw_hash.rb 0.00% <ø> (ø)
lib/puppet/functions/apache/bool2httpd.rb 0.00% <0.00%> (ø)
lib/puppet/functions/apache/pw_hash.rb 0.00% <ø> (ø)
lib/puppet/functions/apache_pw_hash.rb 0.00% <ø> (ø)
lib/puppet/functions/bool2httpd.rb 0.00% <ø> (ø)
lib/puppet/provider/a2mod.rb 31.57% <ø> (ø)
lib/puppet/provider/a2mod/a2mod.rb 61.11% <ø> (ø)
lib/puppet/provider/a2mod/gentoo.rb 93.84% <ø> (ø)
lib/puppet/provider/a2mod/modfix.rb 75.00% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e2dae...96e429d. Read the comment docs.

@ekohl
Copy link
Collaborator Author

ekohl commented Jan 11, 2021

RHEL 7 acceptance test failed with some internal server error so I'm guessing that's unrelated.

This corrects some module packages for Ubuntu 16.04. suphp was actually
removed. The other packages are transitional packages. Using the modern
ones aligns them with newer versions. It also greatly simplifies the
params code.
@sanfrancrisko
Copy link
Contributor

RHEL 7 acceptance test failed with some internal server error so I'm guessing that's unrelated.

Yeah, I doubt it's related to your change - I'll keep an eye on it on this 2nd run after the rebase 🤞

@sanfrancrisko sanfrancrisko self-assigned this Jan 18, 2021
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @ekohl !

@sanfrancrisko sanfrancrisko changed the title Correct Ubuntu 16.04 packages (FIX) Correct PHP packages on Ubuntu 16.04 Jan 18, 2021
@sanfrancrisko sanfrancrisko merged commit 6b1d99c into puppetlabs:main Jan 18, 2021
@ekohl ekohl deleted the clean-ubuntu branch January 18, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants