(IAC-1186) Add $use_port_for_filenames parameter #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using $use_servername_for_filenames = true, virtual hosts with the same $servername but a different $port will introduce a duplicate resource declaration. Introduce a $use_port_for_filenames that act in concert with $use_servername_for_filenames to avoid this situation.
|
This is a follow-up to #2086, so ping @sanfrancrisko and @sheenaajay who worked on this previous PR and @DavidS who proposed this change in IAC-1186. |
Codecov Report
@@ Coverage Diff @@
## main #2122 +/- ##
=======================================
Coverage 56.36% 56.36%
=======================================
Files 12 12
Lines 220 220
=======================================
Hits 124 124
Misses 96 96 Continue to review full report at Codecov.
|
smortex
force-pushed
the
use_port_for_filenames
branch
2 times, most recently
from
2612306
to
352f9f2
Compare
smortex
force-pushed
the
use_port_for_filenames
branch
from
352f9f2
to
fb2a84f
Compare
sanfrancrisko
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using $use_servername_for_filenames = true, virtual hosts with the
same $servername but a different $port will introduce a duplicate
resource declaration.
Introduce a $use_port_for_filenames that act in concert with
$use_servername_for_filenames to avoid this situation.