Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for uri for severname with use_servername_for_filenames #2150

Merged
merged 1 commit into from
May 17, 2021
Merged

support for uri for severname with use_servername_for_filenames #2150

merged 1 commit into from
May 17, 2021
+106 −2

Conversation

Zarne
Copy link
Contributor

@Zarne Zarne commented May 11, 2021 •
edited
Loading

in the apache documentation https://httpd.apache.org/docs/2.4/fr/mod/core.html#servername
Syntax: ServerName [scheme://]domain-name|ip-address[:port]
add support for this syntax when use_servername_for_filenames is set to true.

@Zarne Zarne requested a review from a team as a code owner May 11, 2021 13:01
@CLAassistant
Copy link

CLAassistant commented May 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

apache::vhost is a type

Breaking changes to this file WILL impact these 128 modules (exact match):
Breaking changes to this file MAY impact these 34 modules (near match):

This module is declared in 175 of 576 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@Zarne
authorize uri for severname with use_servername_for_filenames
88a998b 
fix rubocop

fix rspec

fix rubocop

fix rubocop
@pmcmaw pmcmaw added the feature label May 17, 2021
@pmcmaw
Copy link
Contributor

pmcmaw commented May 17, 2021

Thank you for taking the time to contribute to our supported module.
Great change and test coverage, again thank you :-)

@pmcmaw pmcmaw merged commit d237c5f into puppetlabs:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zarne @CLAassistant @pmcmaw