Allow custom userdir directives #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`UserDir` can be various forms of strings (see https://httpd.apache.org/docs/2.4/howto/public_html.html) whereas `Directory` must be an absolute path. This allows UserDir to be specified separately. The unit test showing multiple values for `$path` seems to be incorrect according to https://httpd.apache.org/docs/2.4/mod/core.html#directory
apache::mod::userdir is a classthat may have no external impact to Forge modules. This module is declared in 175 of 576 indexed public
|
ekohl
requested changes
Jul 2, 2021
ekohl
approved these changes
Jul 20, 2021
|
Perhaps another reviewer can also take a look (I only got merge permissions recently). If nobody takes a look in a few days I'll merge it. |
|
Look's good to me so gonna go ahead and merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserDircan be various forms of strings (seehttps://httpd.apache.org/docs/2.4/howto/public_html.html) whereas
Directorymust be an absolute path. This allows UserDir to bespecified separately.
The unit test showing multiple values for
$pathseems to be incorrectaccording to https://httpd.apache.org/docs/2.4/mod/core.html#directory