-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow docroot with mod_vhost_alias virtual_docroot
#2195
Allow docroot with mod_vhost_alias virtual_docroot
#2195
Conversation
apache::vhost is a typethat may have no external impact to Forge modules. This module is declared in 173 of 578 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@yakatz Thanks for putting in the work. |
DocumentRoot is used for other directives when a Virtual Document Root is not found.
For backwards compatibility,
docrootis still ignored unless you set thevirtual_use_default_docroottotrue.For example, to show a custom 404 message, you might use mod_rewrite, but that needs a
DocumentRootto be set: