Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Fedora < 18 #2238

Merged
merged 2 commits into from
May 23, 2022
Merged

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented May 20, 2022

The goal of this PR is to simplify Fedora handling. By now it can be assumed every Fedora is on Apache 2.4 and most users can be expected to run on Red Hat. Fedora isn't formally in metadata.json so this is best effort anyway. Users do not lose anything by this change, but for developers there is less code to maintain.

ekohl added 2 commits May 20, 2022 12:05
Fedora 34 is going EOL in 20 days. Trying to support Fedora < 18 is
unreasonable.
This is more likely to be used since Fedora 28 is EOL.
@ekohl ekohl requested a review from a team as a code owner May 20, 2022 10:10
@puppet-community-rangefinder
Copy link

apache::version is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 174 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl
Copy link
Collaborator Author

ekohl commented May 20, 2022

Failure looks unrelated:

WARNING: Unsuported provisioner 'provision::docker', try abs/docker/docker_exp/provision_service/vagrant/vmpooler
Provisioning litmusimage/oraclelinux:6 using provision::docker provisioner.
rake aborted!
provisioning of litmusimage/oraclelinux:6 failed.

@david22swan
Copy link
Member

@ekohl This looks good to us so gonna go ahead and merge.

@david22swan david22swan merged commit 7b3876d into puppetlabs:main May 23, 2022
@ekohl ekohl deleted the drop-ancient-fedora branch May 23, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants