Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let limitreqfieldsize and limitreqfields be integers #2240

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Let limitreqfieldsize and limitreqfields be integers #2240

merged 1 commit into from
Jun 8, 2022

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Jun 7, 2022 •
edited
Loading

We have run with limitreqfieldsize and limitreqfields values as
integers for a long time.

Checking

these are indeed integers.

@traylenator
Let limitreqfieldsize and limitreqfields be integers
9d089b1 
We have run with `limitreqfieldsize` and `limitreqfields` be integers these values as
integers for a long time.

Checking

* https://httpd.apache.org/docs/2.4/mod/core.html#limitrequestfieldsize
* https://httpd.apache.org/docs/2.4/mod/core.html#limitrequestfields

these are indeed integers.
@traylenator traylenator requested a review from a team as a code owner June 7, 2022 15:27
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

apache is a class

Breaking changes to this file WILL impact these 144 modules (exact match):
Breaking changes to this file MAY impact these 55 modules (near match):

This module is declared in 174 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@traylenator
Copy link
Contributor Author

The CLA is signed due to the agreement between CERN IT department and puppetlabs.

@chelnak
Copy link
Contributor

chelnak commented Jun 7, 2022

LGTM Thank you 👍

@david22swan david22swan merged commit 5666926 into puppetlabs:main Jun 8, 2022
@david22swan
Copy link
Member

@traylenator Thank you for catching this before the release went out

@traylenator traylenator deleted the limitreq branch June 8, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@traylenator @CLAassistant @chelnak @david22swan @ia-content