Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring CRS paranoia level #2270

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

Vincevrp
Copy link
Contributor

No description provided.

@Vincevrp Vincevrp requested a review from a team as a code owner July 29, 2022 10:40
@puppet-community-rangefinder
Copy link

apache::mod::security is a class

that may have no external impact to Forge modules.

This module is declared in 174 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan
Copy link
Member

@Vincevrp Hey, just giving this a quick look at this, and your other tests, and one quick shout on all of them is that they would require test coverage to be added to them.
We can't really add if it's not proven that it works as intended.

@Vincevrp
Copy link
Contributor Author

Vincevrp commented Aug 1, 2022

@david22swan I've added some tests for the paranoia level parameters. Please let me know if this does not suffice.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for getting back so soon on the test's.
Once your other PRs are updated the same they should be good to go also.
Next release is planned for this Friday, so your changes should be out then.

@david22swan david22swan merged commit 922c95e into puppetlabs:main Aug 1, 2022
@Vincevrp Vincevrp deleted the crs-paranoia-level branch August 1, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants