Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding CRS anomaly threshold per vhost #2273

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Allow overriding CRS anomaly threshold per vhost #2273

merged 2 commits into from
Aug 4, 2022
+52 −1

Conversation

Vincevrp
Copy link
Contributor

No description provided.

@Vincevrp Vincevrp requested a review from a team as a code owner July 29, 2022 14:01
@puppet-community-rangefinder
Copy link

apache::vhost is a type

Breaking changes to this file WILL impact these 128 modules (exact match):
Breaking changes to this file MAY impact these 36 modules (near match):

This module is declared in 174 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@Vincevrp Vincevrp force-pushed the vhost-anomaly-override branch 2 times, most recently from c9ba16e to e9642ad Compare August 1, 2022 20:23
@Vincevrp
Copy link
Contributor Author

Vincevrp commented Aug 3, 2022

@david22swan This one should also be good to go. Please let me know if you require any other changes.

david22swan
david22swan approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

On small comment on the new types though, the Default is only needed when declaring less than or equal to a given number. If you only gives a single value it assumes Default as the second one.

@david22swan david22swan merged commit 1d436fd into puppetlabs:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
community feature needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vincevrp @david22swan @ia-content