Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize CRS DOS protection #2280

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Parameterize CRS DOS protection #2280

merged 1 commit into from
Sep 5, 2022
+62 −4

Conversation

Vincevrp
Copy link
Contributor

@Vincevrp Vincevrp commented Aug 5, 2022

No description provided.

@Vincevrp Vincevrp requested a review from a team as a code owner August 5, 2022 11:51
@puppet-community-rangefinder
Copy link

apache::mod::security is a class

that may have no external impact to Forge modules.

This module is declared in 174 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@Vincevrp Vincevrp force-pushed the dos-protection branch 2 times, most recently from 53736c1 to f249fa2 Compare August 5, 2022 13:23
david22swan
david22swan approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit bc9dc3e into puppetlabs:main Sep 5, 2022
@david22swan
Copy link
Member

@Vincevrp That's it merged.
Thanks for getting back so fast on the changes and sorry that it to so long for a response

@Vincevrp Vincevrp deleted the dos-protection branch September 5, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vincevrp @david22swan @ia-content