Simplify the logic in _require.erb #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we take the expression:
!(_item['require'] && _item['require'] != '') && _item['require'] !~ /unmanaged/i && !(_item['auth_require'])
This is hard to read, but equal to:
(!_item['require'] || _item['require'] == '') && _item['require'] !~ /unmanaged/i && !(_item['auth_require'])
This makes it easier to see that item must be `nil` or `''`. Those will
never match `/unmanaged/i` so it can be simplified to:
(!_item['require'] || _item['require'] == '') && !(_item['auth_require'])
Just before it is a block that already checks the last section, so it
can be reduced to an elsif on that block.
david22swan
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we take the expression:
This is hard to read, but equal to:
This makes it easier to see that item must be
nilor''. Those will never match/unmanaged/iso it can be simplified to:Just before it is a block that already checks the last section, so it can be reduced to an elsif on that block.