(maint) Add variable manage_vhost_enable_dir #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david22swan
force-pushed
the
maint/enable_vhost_enable_dir
branch
from
c9060ec
to
883be68
Compare
chelnak
reviewed
Sep 9, 2022
david22swan
force-pushed
the
maint/enable_vhost_enable_dir
branch
from
883be68
to
2c3dd4f
Compare
chelnak
previously approved these changes
Sep 9, 2022
david22swan
changed the title
Additional variable added at request of community to allow for `vhost_enable_dir` to be disabled on Debian systems. Due to the way in which aid variable inherits from the params manifest, simply setting it to `undef` does not work as when this is done it's logic assumes it should inherit from the default params value.
david22swan
force-pushed
the
maint/enable_vhost_enable_dir
branch
from
2c3dd4f
to
632a969
Compare
LukasAud
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional variable added at request of community to allow for
vhost_enable_dirto be disabled on Debian systems.Due to the way in which aid variable inherits from the params manifest, simply setting it to
undefdoes not work as when this is done it's logic assumes it should inherit from the default params value.