Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdksync - (CONT-189) Remove support for RedHat6 / OracleLinux6 / Scientific6 #2326

Merged
merged 4 commits into from
Oct 7, 2022
Merged

pdksync - (CONT-189) Remove support for RedHat6 / OracleLinux6 / Scientific6 #2326

merged 4 commits into from
Oct 7, 2022

Conversation

david22swan
Copy link
Member

CONT-189/remove_os_support
pdk version: 2.5.0

@david22swan david22swan requested a review from a team as a code owner October 7, 2022 09:06
@david22swan david22swan changed the title pdksync - CONT-189/remove_os_support pdksync - (CONT-189) Remove support for RedHat6 / OracleLinux6 / Scientific6 Oct 7, 2022
LukasAud
LukasAud previously approved these changes Oct 7, 2022
View reviewed changes
ekohl
ekohl reviewed Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dropping EL6 implies dropping Apache 2.0 support. Any plans on really ripping that out? It would massively clean up the module.

@david22swan david22swan force-pushed the pdksync_CONT-189/remove_os_support branch from 392ec0e to b7dc6da Compare October 7, 2022 10:49
ekohl
ekohl requested changes Oct 7, 2022
View reviewed changes
spec/classes/mod/info_spec.rb Outdated Show resolved Hide resolved
spec/classes/mod/spec_helper_local.rb Outdated Show resolved Hide resolved
@david22swan david22swan force-pushed the pdksync_CONT-189/remove_os_support branch from b7dc6da to fb01b21 Compare October 7, 2022 13:57
@david22swan david22swan force-pushed the pdksync_CONT-189/remove_os_support branch from fb01b21 to 359a589 Compare October 7, 2022 14:31
@david22swan
Copy link
Member Author

I think dropping EL6 implies dropping Apache 2.0 support. Any plans on really ripping that out? It would massively clean up the module.

That will be coming in a later PR to remove compatibility.
For now we are just removing support, with the compatibility work scheduled for when we have more time to dedicate to it.

@chelnak chelnak merged commit 4922544 into main Oct 7, 2022
@chelnak chelnak deleted the pdksync_CONT-189/remove_os_support branch October 7, 2022 15:41
@praj1001 praj1001 mentioned this pull request Sep 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

@LukasAud LukasAud LukasAud approved these changes

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
bugfix hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@david22swan @ekohl @chelnak @LukasAud