Make serveradmin an optional parameter and use it #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since fc6cced the parameter no longer ends up in the main configuration. It was still used in apache::mod::shib until 049fd54. Since then it's been unused. This changes it to an optional non-empty string which means it doesn't change the default config, but still allows users to set the ServerAdmin in the main Apache config. Fixes: fc6cced
david22swan
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fc6cced the parameter no longer ends up in the main configuration. It was still used in apache::mod::shib until 049fd54. Since then it's been unused.
This changes it to an optional non-empty string which means it doesn't change the default config, but still allows users to set the ServerAdmin in the main Apache config.