Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LimitRequestLine parameter #2345

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

stefan-ahrefs
Copy link
Contributor

Adds optional parameter for setting the limit on the allowed size of a client's HTTP request-line
New PR reopened for closed PR #2208
Added parameter definition and code for testing

@stefan-ahrefs stefan-ahrefs requested a review from a team as a code owner December 2, 2022 09:46
@puppet-community-rangefinder
Copy link

apache is a class

Breaking changes to this file WILL impact these 144 modules (exact match):
Breaking changes to this file MAY impact these 56 modules (near match):

This module is declared in 176 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank's for getting that spec test added.
This all looks good to me so I'll go ahead and merge.

@david22swan david22swan merged commit 255b005 into puppetlabs:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants