vhost: Make ProxyAddHeaders configureable #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
proxyaddheaders
branch
2 times, most recently
from
ae22bb4
to
be38895
Compare
ekohl
previously approved these changes
Jan 10, 2023
bastelfreak
force-pushed
the
proxyaddheaders
branch
from
be38895
to
e2c5792
Compare
It's a valid usecase to set ProxyAddHeaders to Off. That's currently only possible when other proxy settings are configured as well. It needs to be independant.
bastelfreak
force-pushed
the
proxyaddheaders
branch
from
e2c5792
to
3f6e5ee
Compare
|
Thx for putting in the work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a valid usecase to set ProxyAddHeaders to Off. That's currently only possible when other proxy settings are configured as well. It needs to be independant.