Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2374) Suse: Switch modsec_default_rules to array #2375

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

bastelfreak
Copy link
Collaborator

This fixes #2374. The issue was discovered in #2373 while fixing #2371.

@bastelfreak bastelfreak requested a review from a team as a code owner January 31, 2023 10:45
@puppet-community-rangefinder
Copy link

apache::params is a class

Breaking changes to this file WILL impact these 7 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 176 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

175d6d4 broke the template. This commit
switches to proper structured facts.
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 1e21718 into puppetlabs:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suse: wrong default for modsec_default_rules
4 participants