Adding mod_version module to be activated by default #2380
Conversation
|
|
apache::mod::version is a classthat may have no external impact to Forge modules. This module is declared in 176 of 580 indexed public
|
|
As a user of puppetlabs-apache I strongly support this PR as it re-adds the accidentally removed module version, which is an essential module and needs to be part of default_mods too. Just think about .htaccess files distributed with various software or software addons. But may I suggest adding the version module to default_mods.pp again too, @Q-Storm? |
|
Thanks @jnk0 I added the the module to the default_mods.pp |
| # @see https://httpd.apache.org/docs/current/mod/mod_version.html for additional documentation. | ||
| # | ||
| class apache::mod::version { | ||
| if $facts['os']['family'] == 'debian' { |
There was a problem hiding this comment.
Debian , if you want to get the casing right. Though I see it's also wrong in many other places.
| if $facts['os']['family'] == 'debian' { | ||
| warning("${module_name}: module version_module is built-in and can't be loaded") | ||
| } else { | ||
| ::apache::mod { 'version': } |
There was a problem hiding this comment.
The leading :: is not needed. AFAIK it never was for defines, but certainly since we dropped Puppet < 4 it's no longer needed.
re adding mod_version which was accidentally removed with the drop of "apache 2.2 Support" in #2329.