Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example code for apache::vhost::php_values #2384

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Fix example code for apache::vhost::php_values #2384

merged 1 commit into from
Feb 10, 2023

Conversation

gcoxmoz
Copy link
Contributor

@gcoxmoz gcoxmoz commented Feb 8, 2023

The php_values parameter requires a Hash, but gives examples from the ~v7 era when other values were allowed.

@gcoxmoz
Fix example code for apache::vhost::php_values
113ecc0 
The `php_values` parameter requires a Hash, but gives examples from the ~v7 era when other values were allowed.
@gcoxmoz gcoxmoz requested a review from a team as a code owner February 8, 2023 00:17
@puppet-community-rangefinder
Copy link

apache::vhost is a type

Breaking changes to this file WILL impact these 128 modules (exact match):
Breaking changes to this file MAY impact these 36 modules (near match):

This module is declared in 176 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

david22swan
david22swan approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 4086506 into puppetlabs:main Feb 10, 2023
@gcoxmoz gcoxmoz deleted the php_values-doc branch February 10, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcoxmoz @david22swan @ia-content