Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strickter loglevel syntax verification #2397

Merged
merged 4 commits into from Sep 20, 2023

Conversation

igt-marcin-wasilewski
Copy link
Contributor

Apache::LogLevel allows invalid strings like 'warning' which are not accepted by apache httpd

@igt-marcin-wasilewski igt-marcin-wasilewski requested a review from a team as a code owner March 24, 2023 15:20
@CLAassistant
Copy link

CLAassistant commented Mar 24, 2023

CLA assistant check
All committers have signed the CLA.

@LukasAud
Copy link
Contributor

Very sorry for the long delay in approval for this PR. We have been busy with key maintenance around our modules.

types/loglevel.pp Outdated Show resolved Hide resolved
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex
Copy link
Collaborator

smortex commented Sep 15, 2023

Very sorry for the long delay in approval for this PR. We have been busy with key maintenance around our modules.

@LukasAud, has the situation improved? 😁

@Ramesh7 Ramesh7 added the bugfix label Sep 20, 2023
@Ramesh7 Ramesh7 merged commit ab45655 into puppetlabs:main Sep 20, 2023
39 checks passed
@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 20, 2023

Thanks @smortex for your patience, sorry for delay as this came to my radar just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants