Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CONT-772) Puppet 8 support / Drop Puppet 6 #2405

Merged
merged 18 commits into from Apr 21, 2023
Merged

(CONT-772) Puppet 8 support / Drop Puppet 6 #2405

merged 18 commits into from Apr 21, 2023

Conversation

LukasAud
Copy link
Contributor

No description provided.

@LukasAud LukasAud force-pushed the CONT-772-Puppet_8_support branch 2 times, most recently from b91c917 to fa5472f Compare April 18, 2023 21:46
@LukasAud LukasAud marked this pull request as ready for review April 20, 2023 13:45
@LukasAud LukasAud requested a review from a team as a code owner April 20, 2023 13:45
jordanbreen28
jordanbreen28 previously approved these changes Apr 21, 2023
View reviewed changes
.rubocop_todo.yml Outdated Show resolved Hide resolved
jordanbreen28
jordanbreen28 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - CI had already passed.

@jordanbreen28 jordanbreen28 merged commit 38945c5 into main Apr 21, 2023
37 of 38 checks passed
@jordanbreen28 jordanbreen28 deleted the CONT-772-Puppet_8_support branch April 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasAud @jordanbreen28