Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CAT-1449) - Remove deprecated parameters for scriptaliases & passenger #2470

Merged
merged 2 commits into from Sep 22, 2023
Merged

(CAT-1449) - Remove deprecated parameters for scriptaliases & passenger #2470

merged 2 commits into from Sep 22, 2023

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Sep 22, 2023 •
edited

Summary

Cleanup for deprecated content :

  • scriptaliases parameter
  • passanger params

Additional Context

Thanks @ekohl for pointing out the deprecated content and raising the bar for apache module.
Also thanks #2469 which I used it to fix scriptaliases spec fixes.

Checklist

  • 馃煝 Spec tests.
  • 馃煝 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Ramesh7 Ramesh7 mentioned this pull request Sep 22, 2023
Merged
3 tasks
@Ramesh7 Ramesh7 force-pushed the CAT-1449-deprecation-cleanup branch 2 times, most recently from c2a7444 to 5de663b Compare September 22, 2023 12:49
ekohl
ekohl reviewed Sep 22, 2023
View reviewed changes
HISTORY.md Outdated Show resolved Hide resolved
manifests/mod/passenger.pp Outdated Show resolved Hide resolved
manifests/mod/passenger.pp Outdated Show resolved Hide resolved
@Ramesh7 Ramesh7 force-pushed the CAT-1449-deprecation-cleanup branch 4 times, most recently from 80b4c03 to 304ea95 Compare September 22, 2023 14:04
@Ramesh7 Ramesh7 changed the title (CAT-1449) - Cleanup for deprecated content from module (CAT-1449) - Cleanup of deprecated parameters and adding new params for passenger Sep 22, 2023
@Ramesh7 Ramesh7 changed the title (CAT-1449) - Cleanup of deprecated parameters and adding new params for passenger (CAT-1449) - Remove deprecated parameters for scriptaliases & passenger and adding new params for passenger mod Sep 22, 2023
@Ramesh7 Ramesh7 marked this pull request as ready for review September 22, 2023 15:16
@Ramesh7 Ramesh7 mentioned this pull request Sep 22, 2023
Closed
bastelfreak
bastelfreak previously approved these changes Sep 22, 2023
View reviewed changes
smortex
smortex reviewed Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be something weird with passenger_resist_deployment_errors as I do not think it was removed. It is an "Enterprise only" feature and I have not tested it, but the doc still reference it.

manifests/mod/passenger.pp Outdated Show resolved Hide resolved
manifests/mod/passenger.pp Outdated Show resolved Hide resolved
@smortex
Copy link
Collaborator

smortex commented Sep 22, 2023

Also wondering if having one PR for passenger and a separate one for scriptaliases would make the changelog more readable?

ekohl
ekohl requested changes Sep 22, 2023
View reviewed changes
manifests/mod/passenger.pp Outdated Show resolved Hide resolved
manifests/mod/passenger.pp Outdated Show resolved Hide resolved
manifests/mod/passenger.pp Outdated Show resolved Hide resolved
templates/vhost/_scriptalias.erb Outdated Show resolved Hide resolved
@Ramesh7 Ramesh7 changed the title (CAT-1449) - Remove deprecated parameters for scriptaliases & passenger and adding new params for passenger mod (CAT-1449) - Remove deprecated parameters for scriptaliases & passenger Sep 22, 2023
@Ramesh7
Copy link
Contributor Author

Ramesh7 commented Sep 22, 2023

Also wondering if having one PR for passenger and a separate one for scriptaliases would make the changelog more readable?

Have removed new addition of params as part of this PR, just removed deprecated params.

ekohl
ekohl previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note, but looks good.

manifests/mod/passenger.pp Outdated Show resolved Hide resolved
@Ramesh7 Ramesh7 requested a review from ekohl September 22, 2023 17:23
@praj1001
Copy link
Contributor

LGTM

praj1001
praj1001 previously approved these changes Sep 22, 2023
View reviewed changes
@praj1001
Copy link
Contributor

LGTM

@Ramesh7 Ramesh7 merged commit 502a891 into main Sep 22, 2023
38 checks passed
@Ramesh7 Ramesh7 deleted the CAT-1449-deprecation-cleanup branch September 22, 2023 18:43
@Ramesh7 Ramesh7 mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praj1001 praj1001 praj1001 approved these changes

@smortex smortex Awaiting requested review from smortex smortex is a code owner

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ramesh7 @smortex @praj1001 @ekohl @bastelfreak