Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct handling of $serveraliases as string #2518

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Correct handling of $serveraliases as string #2518

merged 1 commit into from
Jan 10, 2024

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Jan 6, 2024

Fixes #2517

@ekohl ekohl requested review from bastelfreak, smortex and a team as code owners January 6, 2024 16:22
smortex
smortex reviewed Jan 6, 2024
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding tests for this parameter, need some tweaking and should be good to go!

manifests/vhost.pp Outdated Show resolved Hide resolved
spec/defines/vhost_spec.rb Outdated Show resolved Hide resolved
@ekohl
Copy link
Collaborator Author

ekohl commented Jan 9, 2024

Test failure is unrelated.

smortex
smortex approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex added the bugfix label Jan 9, 2024
@ekohl ekohl mentioned this pull request Jan 10, 2024
Merged
1 task
@smortex
Copy link
Collaborator

smortex commented Jan 10, 2024

This feel safe so I will merge it. Do you want to trigger a 12.0.2 release?

@smortex smortex merged commit 928f91d into puppetlabs:main Jan 10, 2024
43 checks passed
@ekohl ekohl deleted the fix-serveralias-string branch January 10, 2024 19:51
@ekohl
Copy link
Collaborator Author

ekohl commented Jan 10, 2024

I can't trigger it from my phone

@bastelfreak
Copy link
Collaborator

release PR: #2519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaffen rwaffen rwaffen approved these changes

@smortex smortex smortex approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

serveraliases template creation fails on String
5 participants
@ekohl @smortex @bastelfreak @rwaffen @ia-content