vhost: Allow customizing show_diff #2536
Merged
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A vhost configuration file may contain sensitive information. For example when mod_auth_openidc is used then the file may contain OIDCCryptoPassphrase. This introduces the parameter to allow users to hide diff when applying manifests, to avoid leaking secrets to outputs.
kajinamit
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
|
I was just about to implement this myself. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow customizing show_diff of vhost configuration file
Additional Context
A vhost configuration file may contain sensitive information. For example when mod_auth_openidc is used then the file may contain OIDCCryptoPassphrase. This introduces the parameter to allow users to hide diff when applying manifests, to avoid leaking secrets to outputs.
Related Issues (if any)
N/A
Checklist
puppet apply)