-
Notifications
You must be signed in to change notification settings - Fork 459
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-apt
base: v7.4.1
head repository: puppetlabs/puppetlabs-apt
compare: v7.4.2
- 13 commits
- 15 files changed
- 12 contributors
Commits on Mar 11, 2020
-
do not specify file modes unless relevant
MODULES-10583 makes a good point: "why are you messing with my file permissions"? In my case, the entire reason I made the following change (in PR #906): ab2e06b MODULES-10548: make files readonly ... is exactly *because* Puppet was changing the file modes from under me. I was migrating from our own in-house APT module to the forge one, and our module did *not* intervene in those file modes: it left the file resources alone. Which means we could have a directive like this: File { owner => root, group => root, mode => '444', ensure => file, } ... which made all files readonly by default. So when I migrated to the Puppetlabs APT module, modes were changed to be writable, which I did not want. As I reasoned in MODULES-10548, having files readonly provides an excellent indicator that a file is managed by Puppet, even if some module does not add a warning header - either because it forgot or because it's impossible. But I also understand if people do not like that policy. I think the proper way of doing this is not specifying a mode at all, and let local site-specific policies apply. I specifically proppose this as an alternative to #921 because I believe adding more parameters to the resources will needlessly complicate the script, when we have a native, Puppet-DSL supported way of changing those modes according to the right scope and context. In a similar way, we might want to reconsider user and group ownership of the files, but that can be done in a later time. This reverts commit 316fd8f. Signed-off-by: Antoine Beaupré <anarcat@debian.org>
Configuration menu - View commit details
-
Copy full SHA for 4d8b3e1 - Browse repository at this point
Copy the full SHA 4d8b3e1View commit details
Commits on Mar 12, 2020
-
Merge pull request #923 from anarcat/no-mode
Do not specify file modes unless relevant
Configuration menu - View commit details
-
Copy full SHA for e69426f - Browse repository at this point
Copy the full SHA e69426fView commit details
Commits on Mar 13, 2020
-
(maint) Update apt custom facts
This commit updates apt custom facts because the evaluation of custom facts code has changed between facter 2 and facter 4. In facter 2, when a custom fact is loaded, the code in `add` block was not executed. In facter 4, when a custom fact is loaded, the code outside `setcode` block is executed(same as Facter 3).
gimmy committedMar 13, 2020 Configuration menu - View commit details
-
Copy full SHA for 6786d50 - Browse repository at this point
Copy the full SHA 6786d50View commit details
Commits on Mar 19, 2020
-
apt-mark supports the following syntax: * showauto * showmanual * showhold Signed-off-by: Vadim Chernyshev <tryfunc@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ce7ceb3 - Browse repository at this point
Copy the full SHA ce7ceb3View commit details
Commits on Apr 8, 2020
-
Merge pull request #927 from tryfunc/fix_apt_mark
fix apt-mark syntax
Configuration menu - View commit details
-
Copy full SHA for ddf1ad0 - Browse repository at this point
Copy the full SHA ddf1ad0View commit details
Commits on Apr 10, 2020
-
Merge pull request #924 from gimmyxd/facter_4
(maint) Update apt custom facts
carabasdaniel authoredApr 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 04b6a89 - Browse repository at this point
Copy the full SHA 04b6a89View commit details
Commits on Apr 27, 2020
-
Add net-ssh dependency gems to development group
Daniel Carabas committedApr 27, 2020 Configuration menu - View commit details
-
Copy full SHA for 84c69f9 - Browse repository at this point
Copy the full SHA 84c69f9View commit details
Commits on Apr 28, 2020
-
Merge pull request #931 from puppetlabs/pdksync_dependency_gems_update
pdksync - Add dependency gems to development group
Configuration menu - View commit details
-
Copy full SHA for 2df4e59 - Browse repository at this point
Copy the full SHA 2df4e59View commit details
Commits on May 12, 2020
-
David Swan committed
May 12, 2020 Configuration menu - View commit details
-
Copy full SHA for 966a8af - Browse repository at this point
Copy the full SHA 966a8afView commit details
Commits on May 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 98afb5d - Browse repository at this point
Copy the full SHA 98afb5dView commit details
Commits on May 14, 2020
-
Merge pull request #933 from puppetlabs/pdksync_PDK_UPDATE
pdksync - (maint) - Pdk Update
Configuration menu - View commit details
-
Copy full SHA for 15a9db1 - Browse repository at this point
Copy the full SHA 15a9db1View commit details -
Auto-release committed
May 14, 2020 Configuration menu - View commit details
-
Copy full SHA for c5e63a1 - Browse repository at this point
Copy the full SHA c5e63a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65ffdce - Browse repository at this point
Copy the full SHA 65ffdceView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v7.4.1...v7.4.2