Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-apt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.4.1
Choose a base ref
...
head repository: puppetlabs/puppetlabs-apt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.4.2
Choose a head ref
  • 13 commits
  • 15 files changed
  • 12 contributors

Commits on Mar 11, 2020

  1. do not specify file modes unless relevant

    MODULES-10583 makes a good point: "why are you messing with my file
    permissions"? In my case, the entire reason I made the following
    change (in PR #906):
    
    ab2e06b MODULES-10548: make files readonly
    
    ... is exactly *because* Puppet was changing the file modes from under
    me. I was migrating from our own in-house APT module to the forge one,
    and our module did *not* intervene in those file modes: it left the
    file resources alone. Which means we could have a directive like this:
    
        File {
            owner   => root,
            group   => root,
            mode    => '444',
            ensure  => file,
        }
    
    ... which made all files readonly by default. So when I migrated to
    the Puppetlabs APT module, modes were changed to be writable, which I
    did not want.
    
    As I reasoned in MODULES-10548, having files readonly provides an
    excellent indicator that a file is managed by Puppet, even if some
    module does not add a warning header - either because it forgot or
    because it's impossible. But I also understand if people do not like
    that policy.
    
    I think the proper way of doing this is not specifying a mode at all,
    and let local site-specific policies apply. I specifically proppose
    this as an alternative to #921 because I believe adding more
    parameters to the resources will needlessly complicate the script,
    when we have a native, Puppet-DSL supported way of changing those
    modes according to the right scope and context.
    
    In a similar way, we might want to reconsider user and group ownership
    of the files, but that can be done in a later time.
    
    This reverts commit 316fd8f.
    
    Signed-off-by: Antoine Beaupré <anarcat@debian.org>
    anarcat committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    4d8b3e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Merge pull request #923 from anarcat/no-mode

    Do not specify file modes unless relevant
    sanfrancrisko authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    e69426f View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. (maint) Update apt custom facts

    This commit updates apt custom facts because the evaluation
    of custom facts code has changed between facter 2 and facter 4.
    In facter 2, when a custom fact is loaded, the code in `add` block
    was not executed.
    In facter 4, when a custom fact is loaded, the code outside `setcode`
    block is executed(same as Facter 3).
    gimmy committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    6786d50 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. fix unless_cmd

    apt-mark supports the following syntax:
    
     * showauto
     * showmanual
     * showhold
    
    Signed-off-by: Vadim Chernyshev <tryfunc@gmail.com>
    tryfunc committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    ce7ceb3 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Merge pull request #927 from tryfunc/fix_apt_mark

    fix apt-mark syntax
    sheenaajay authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    ddf1ad0 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Merge pull request #924 from gimmyxd/facter_4

    (maint) Update apt custom facts
    carabasdaniel authored Apr 10, 2020
    Configuration menu
    Copy the full SHA
    04b6a89 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Add net-ssh dependency gems to development group

    Daniel Carabas committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    84c69f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Merge pull request #931 from puppetlabs/pdksync_dependency_gems_update

    pdksync - Add dependency gems to development group
    daianamezdrea authored Apr 28, 2020
    Configuration menu
    Copy the full SHA
    2df4e59 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. (maint) - Pdk Update

    David Swan committed May 12, 2020
    Configuration menu
    Copy the full SHA
    966a8af View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Configuration menu
    Copy the full SHA
    98afb5d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Merge pull request #933 from puppetlabs/pdksync_PDK_UPDATE

    pdksync - (maint) - Pdk Update
    sanfrancrisko authored May 14, 2020
    Configuration menu
    Copy the full SHA
    15a9db1 View commit details
    Browse the repository at this point in the history
  2. Release version 7.4.2

    Auto-release committed May 14, 2020
    Configuration menu
    Copy the full SHA
    c5e63a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    65ffdce View commit details
    Browse the repository at this point in the history
Loading