Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace arm64 for aarch64 in ::apt::source #1012

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

mpdude
Copy link

@mpdude mpdude commented Jan 9, 2022

arm64 is a rather new player in the server market: AWS Gravitron instances use it, but it is also used when running Linux-based VMs on Apple's new M1 chips.

As someone explained on StackOverflow, the Linux Kernel uses aarch64 at the name for this architecture, and that's what is reported by Facter.

Apt, however, uses the arm64 architecture name for this platform.

This mismatch can cause bugs as in puppetlabs/docker, and thus my suggestion is to fix it here in a central location.

I am not familiar with Ruby programming and rspec-based acceptance tests. So, if that's a requirement for getting this merged, any help is greatly appreciated.

@mpdude mpdude requested a review from a team as a code owner January 9, 2022 22:37
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

apt::source is a type

that may have no external impact to Forge modules.

This module is declared in 233 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud LukasAud merged commit 447706d into puppetlabs:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants