Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyring: rename parameters to remove redundancy #1146

Merged
merged 1 commit into from Nov 21, 2023
Merged

keyring: rename parameters to remove redundancy #1146

merged 1 commit into from Nov 21, 2023

Conversation

kenyon
Copy link

@kenyon kenyon commented Nov 21, 2023 •
edited

We don't need apt::keyring::keyring_thing, it should just be apt::keyring::thing.

@kenyon kenyon requested review from bastelfreak, smortex and a team as code owners November 21, 2023 19:01
bastelfreak
bastelfreak approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense. We should keep it open for a while until we've more breaking changes.

@bastelfreak
Copy link
Collaborator

@kenyon can you please rebase so your branch is up2date?

@kenyon
keyring: rename parameters to remove redundancy
2c72290 
We don't need apt::keyring::keyring_thing, it should just be
apt::keyring::thing.
@bastelfreak bastelfreak merged commit 2c72290 into puppetlabs:main Nov 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
community maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenyon @bastelfreak @ia-content