GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Splitting the source url by slashes isn't quite good enough if it has embedded credentials. The easiest solution I can see is to hand off the URI parsing to Ruby, instead of adding more logic in the manifest. Thoughts?
use ruby URI module to parse source origin
Fixes pinning when the repo location includes credentials.
spec for pinning a source with credentials
Given daenney's comment above, I'm going to close this for now. Feel free to update the branch and re-open the PR to address those issues!