Use ruby's 'uri' module to parse the source URI #189

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

rtandy commented Nov 21, 2013

Splitting the source url by slashes isn't quite good enough if it has embedded credentials. The easiest solution I can see is to hand off the URI parsing to Ruby, instead of adding more logic in the manifest. Thoughts?

Ryan Tandy added some commits Jul 23, 2013

use ruby URI module to parse source origin
Fixes pinning when the repo location includes credentials.
Member

hunner commented Mar 26, 2014

Given daenney's comment above, I'm going to close this for now. Feel free to update the branch and re-open the PR to address those issues!

@hunner hunner closed this Mar 26, 2014

@rtandy rtandy deleted the use_ruby_uri_parser branch Oct 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment