Skip to content

Few formatting changes. #200

Closed
wants to merge 2 commits into from

2 participants

@ericsysmin

I have reviewed this module in Geppetto and it seems that there were some formatting issues that had it fail syntax checks. These changes included spacing which wasn't clear, as well as double quotations used when variables were not in the field. Double quotations should be used only when calling variables as per Puppet Documentation in both 2.7 and 3.0 Books. I have corrected these.

There is also an issue with the tests/unattended-upgrades.pp using a - instead of a _ for the test. unattended-upgrades class doesn't exist, while unattended_upgrades class does exist. I believe this is a change that was supposed to be put in but never was.

@hunner hunner commented on the diff Feb 25, 2014
manifests/unattended_upgrades.pp
- validate_bool(
- $auto_fix,
- $minimal_steps,
- $install_on_shutdown,
- $mail_only_on_error,
- $remove_unused,
- $auto_reboot
- )
@hunner
Puppet member
hunner added a note Feb 25, 2014

Why is this an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@hunner hunner commented on the diff Feb 25, 2014
manifests/unattended_upgrades.pp
@@ -62,6 +51,7 @@
file {
'/etc/apt/apt.conf.d/50unattended-upgrades':
content => template('apt/50unattended-upgrades.erb');
+
@hunner
Puppet member
hunner added a note Feb 25, 2014

Splitting these into two separate resources would actually be preferred over adding a newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@hunner
Puppet member
hunner commented Mar 27, 2014

Closing for now. Feel free to reopen when comments have been addressed.

@hunner hunner closed this Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.