Add support to disable/enable installing of recommended packages #251

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants

Setting install_recommends to false helps keeping more control
over installed packages

@prodrive-ci prodrive-ci Add support to disable/enable installing of recommended packages
Setting install_recommends to false helps keeping more control
over installed packages
428431f
Member

daenney commented Feb 27, 2014

This needs rspec tests and also acceptance/Beaker tests to validate that the behaviour change we expect occurs.

This should be an optional value and default to true to reflect current/default Debian policy.

It should be possible to remove this file entirely instead of flipping the policy from false to true to get the default behaviour. As such it would need an ensure param defaulting to file which could be set to absent instead by a user.

Owner

martijndegouw replied Mar 7, 2014

What should this absence depend on?

What about this:
install_recomments = true: ensure file
install_recomments = false: ensure file
install_recomments = undef: ensure absent

Mmm, that might work but could also get you into trouble because of Puppet's weird interpretations of booleans and undef.

I'd be more comfortable with simply having an ensure parameter that you can set to present or absent

apenney commented Mar 7, 2014

I too would prefer to see present/absent with ensure, so 👍 to that.

Member

daenney commented Mar 28, 2014

@martijndegouw: we still need tests on this.

apenney closed this Apr 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment